Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix broken cdk virtual scroll integration #7642

Merged
merged 1 commit into from Sep 26, 2022
Merged

fix(module:select): fix broken cdk virtual scroll integration #7642

merged 1 commit into from Sep 26, 2022

Conversation

ousc
Copy link
Contributor

@ousc ousc commented Sep 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

when set [nzDropdownMatchSelectWidth]="false", there is always a blank area at the bottom of the dropdown.

Issue Number: #7625

What is the new behavior?

make [nzDropdownMatchSelectWidth]="false" behaviar normoal

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

It's related to this PR angular/components#24394

@zorro-bot
Copy link

zorro-bot bot commented Sep 16, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #7642 (bcb2aee) into master (92be537) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7642   +/-   ##
=======================================
  Coverage   92.02%   92.03%           
=======================================
  Files         502      502           
  Lines       16736    16736           
  Branches     2629     2629           
=======================================
+ Hits        15402    15403    +1     
  Misses       1064     1064           
+ Partials      270      269    -1     
Impacted Files Coverage Δ
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 1f10a9c into NG-ZORRO:master Sep 26, 2022
@pr-triage pr-triage bot added the PR: merged label Sep 26, 2022
@ousc ousc deleted the fix_broken_cdk_virtual_scroll_integration branch September 26, 2022 06:46
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants