Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): fix nzContentParams definition error #7668

Merged
merged 1 commit into from Dec 21, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 9, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #7668 (ecc06c3) into master (f02fc69) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7668      +/-   ##
==========================================
+ Coverage   92.01%   92.03%   +0.01%     
==========================================
  Files         502      502              
  Lines       16751    16751              
  Branches     2634     2634              
==========================================
+ Hits        15414    15416       +2     
+ Misses       1066     1065       -1     
+ Partials      271      270       -1     
Impacted Files Coverage Δ
components/drawer/drawer.component.ts 99.03% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NzDrawerComponent Type Definition error
2 participants