Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:code-editor): fix declaration of Window as monaco-editor #7676

Merged
merged 1 commit into from Oct 15, 2022

Conversation

simplejason
Copy link
Member

close #7663

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7663

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 12, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #7676 (a6803c8) into master (16e61be) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a6803c8 differs from pull request most recent head afc27b2. Consider uploading reports for the commit afc27b2 to get more accurate results

@@            Coverage Diff             @@
##           master    #7676      +/-   ##
==========================================
- Coverage   92.03%   92.03%   -0.01%     
==========================================
  Files         502      502              
  Lines       16751    16751              
  Branches     2634     2634              
==========================================
- Hits        15417    15416       -1     
- Misses       1064     1065       +1     
  Partials      270      270              
Impacted Files Coverage Δ
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simplejason simplejason merged commit bdf6507 into NG-ZORRO:master Oct 15, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NG-ZORRO官网提供的Code Editor组件demo例子有问题,编译不过
2 participants