Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): fix datePicker show multi panel #7680

Merged
merged 1 commit into from Oct 17, 2022

Conversation

luckyship
Copy link
Contributor

@luckyship luckyship commented Oct 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7450

What is the new behavior?

it wiill show normally

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #7680 (1492594) into master (1a16154) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1492594 differs from pull request most recent head ccf358b. Consider uploading reports for the commit ccf358b to get more accurate results

@@            Coverage Diff             @@
##           master    #7680      +/-   ##
==========================================
- Coverage   92.02%   92.00%   -0.03%     
==========================================
  Files         502      502              
  Lines       16752    16756       +4     
  Branches     2634     2634              
==========================================
  Hits        15416    15416              
- Misses       1065     1072       +7     
+ Partials      271      268       -3     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 93.78% <100.00%> (+0.07%) ⬆️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luckyship luckyship force-pushed the master branch 3 times, most recently from 24819b2 to 1bee543 Compare October 14, 2022 08:42
@wenqi73
Copy link
Member

wenqi73 commented Oct 15, 2022

This change causes another problem: the cursor in the input element cannot be moved with mousedown

@luckyship luckyship force-pushed the master branch 4 times, most recently from 7c2c264 to 7bb036b Compare October 16, 2022 09:30
@luckyship
Copy link
Contributor Author

This change causes another problem: the cursor in the input element cannot be moved with mousedown

@wenqi73 thanks for pointer my fault, i have filter input element when prevent default event, pls review again

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wenqi73 wenqi73 merged commit ee4872e into NG-ZORRO:master Oct 17, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants