Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): arrow in wrong position for RTL direction #7690

Merged
merged 1 commit into from Oct 25, 2022

Conversation

luckyship
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7373
close: #7373

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #7690 (0ead98d) into master (ee4872e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 0ead98d differs from pull request most recent head 395fd4b. Consider uploading reports for the commit 395fd4b to get more accurate results

@@            Coverage Diff             @@
##           master    #7690      +/-   ##
==========================================
- Coverage   92.03%   92.01%   -0.03%     
==========================================
  Files         502      502              
  Lines       16757    16759       +2     
  Branches     2635     2636       +1     
==========================================
- Hits        15423    15421       -2     
- Misses       1064     1068       +4     
  Partials      270      270              
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 95.21% <100.00%> (+0.05%) ⬆️
components/table/src/table-data.service.ts 80.32% <0.00%> (-4.92%) ⬇️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️
components/date-picker/date-picker.component.ts 94.42% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luckyship luckyship force-pushed the issue-7373 branch 3 times, most recently from 6a78bec to 08a82b7 Compare October 18, 2022 05:32
Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@luckyship
Copy link
Contributor Author

image

@wenqi73 thanks, i have updated style to fix this.

@luckyship luckyship force-pushed the issue-7373 branch 3 times, most recently from 3ace2b7 to 4437368 Compare October 21, 2022 08:22
Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 41b56e4 into NG-ZORRO:master Oct 25, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nz-range-picker]: arrows for range picker in wrong position in case of RTL direction
3 participants