Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: alert): support custom icon #7691

Merged
merged 1 commit into from Nov 18, 2022

Conversation

1wkk
Copy link
Contributor

@1wkk 1wkk commented Oct 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7687
close: #7687

What is the new behavior?

Supported custom icon.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Perhaps a field describing which version the feature was added could be provided, like Ant Design React.

@zorro-bot
Copy link

zorro-bot bot commented Oct 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #7691 (c4222a2) into master (616f59f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7691      +/-   ##
==========================================
+ Coverage   92.03%   92.06%   +0.03%     
==========================================
  Files         502      502              
  Lines       16766    16767       +1     
  Branches     2638     2638              
==========================================
+ Hits        15430    15436       +6     
+ Misses       1069     1062       -7     
- Partials      267      269       +2     
Impacted Files Coverage Δ
components/alert/alert.component.ts 95.31% <100.00%> (+0.07%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

components/alert/style/index.less Outdated Show resolved Hide resolved
@1wkk 1wkk force-pushed the feat/alert-support-custom-icon branch from f92c745 to c4222a2 Compare November 18, 2022 05:00
@1wkk 1wkk requested review from simplejason and removed request for vthinkxie November 18, 2022 05:15
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit cc014a1 into NG-ZORRO:master Nov 18, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom icon in nz-alert
2 participants