Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): textarea-count combined with nzHasFeedback location #7709

Merged
merged 1 commit into from Dec 5, 2022

Conversation

OriginRing
Copy link
Collaborator

fix #7574

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #7709 (393a352) into master (41b56e4) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 393a352 differs from pull request most recent head 1699dd7. Consider uploading reports for the commit 1699dd7 to get more accurate results

@@            Coverage Diff             @@
##           master    #7709      +/-   ##
==========================================
+ Coverage   92.02%   92.04%   +0.02%     
==========================================
  Files         502      502              
  Lines       16759    16759              
  Branches     2636     2636              
==========================================
+ Hits        15422    15426       +4     
+ Misses       1069     1064       -5     
- Partials      268      269       +1     
Impacted Files Coverage Δ
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

components/input/style/index.less Outdated Show resolved Hide resolved
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit ddd44d2 into NG-ZORRO:master Dec 5, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
@OriginRing OriginRing deleted the fix/textarea-count branch March 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzHasFeedback has incorrect position inside nz-textarea-count
2 participants