Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): re-enter Angular zone after icons have been loaded #7719

Merged
merged 1 commit into from Nov 15, 2022

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Nov 11, 2022

Closes: #7714, Closes: #7682

@zorro-bot
Copy link

zorro-bot bot commented Nov 11, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #7719 (232a735) into master (3a638af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7719   +/-   ##
=======================================
  Coverage   92.02%   92.03%           
=======================================
  Files         502      502           
  Lines       16762    16763    +1     
  Branches     2638     2638           
=======================================
+ Hits        15426    15427    +1     
  Misses       1069     1069           
  Partials      267      267           
Impacted Files Coverage Δ
components/icon/icon.directive.ts 97.18% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants