Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): activated value resetting during load on scroll #7725

Merged

Conversation

dev-anton-ko
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • Load on Scroll - Activated Value resets to zero position after the adding of new page of data
  • Multiple Selection - After selecting an item Activated Value resets to the first selected element instead of staying the same. And one have to navigate through all the list again to continue selection. It's significant for selecting by keyboard.

Issue Number: N/A

What is the new behavior?

  • Load on Scroll - Activated Value shifts to the next item of the list
  • Multiple Selection - After selecting an item Activated Value stays the same

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #7725 (5d75470) into master (f6a8044) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7725   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         502      502           
  Lines       16763    16764    +1     
  Branches     2638     2638           
=======================================
+ Hits        15427    15428    +1     
  Misses       1069     1069           
  Partials      267      267           
Impacted Files Coverage Δ
components/select/select.component.ts 91.31% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 9e08be9 into NG-ZORRO:master Nov 27, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants