Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): select on Tab support #7728

Merged
merged 2 commits into from Dec 11, 2022

Conversation

dev-anton-ko
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7622

What is the new behavior?

If nzSelectOnTab is true - selection of an item might be performed by TAB key

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 20, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #7728 (de90b09) into master (f6a8044) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7728      +/-   ##
==========================================
+ Coverage   92.03%   92.07%   +0.04%     
==========================================
  Files         502      502              
  Lines       16763    16774      +11     
  Branches     2638     2641       +3     
==========================================
+ Hits        15427    15445      +18     
+ Misses       1069     1061       -8     
- Partials      267      268       +1     
Impacted Files Coverage Δ
components/select/select.component.ts 91.46% <100.00%> (+0.16%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/alert/alert.component.ts 95.31% <0.00%> (+0.07%) ⬆️
components/image/image-preview.component.ts 94.30% <0.00%> (+0.11%) ⬆️
components/tabs/tab-nav-bar.component.ts 88.65% <0.00%> (+0.70%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit d9f9092 into NG-ZORRO:master Dec 11, 2022
@pr-triage pr-triage bot added the PR: merged label Dec 11, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
* feat(module:select): select on Tab support

* Translation Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants