fix(list): specify template ref context on input to match instantiation #7756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7756 +/- ##
==========================================
- Coverage 92.03% 92.02% -0.02%
==========================================
Files 502 502
Lines 16768 16768
Branches 2638 2638
==========================================
- Hits 15432 15430 -2
- Misses 1069 1070 +1
- Partials 267 268 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* input was specified as TemplateRef<void> but usage of template provides a context * providing a context was/is possible because Angular does not check the template reference and the provided context to match * consuming the context and pass in a template ref with context is also possible because a template ref is TemplateRef<any> per default
pburgmer
force-pushed
the
fix-list-item-renderer-template-context
branch
from
5e952ef
to
f140369
Compare
chenc041
pushed a commit
to chenc041/ng-zorro-antd
that referenced
this pull request
Dec 14, 2022
…NG-ZORRO#7756) * input was specified as TemplateRef<void> but usage of template provides a context * providing a context was/is possible because Angular does not check the template reference and the provided context to match * consuming the context and pass in a template ref with context is also possible because a template ref is TemplateRef<any> per default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently input
nzRenderItemon NzList component is defined asTemplateRef<void>but it is instantiated with a context.It works in current version to pass in a template, which relies on a provided context. Unfortunately template refs and their context are not type checked by Angular. So you can pass in a TemplateRef with context even if a TemplateRef without context is expected by the input. And ng-zorro can provide a context during the instantiation even if the TemplateRef is specified without context.
Issue Number: N/A
What is the new behavior?
Input
nzRenderItemon NzList component is now defined asTemplateRef<{ $implicit: NzSafeAny, index: number}>, the same context type as the template is providing.Does this PR introduce a breaking change?
Other information