LoggingConfigurationParser - Support for using assembly-name as type-alias-prefix #4979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve #4978, so one can do this (Assembly-name in QName-prefix):
See also: https://en.wikipedia.org/wiki/QName
Not happy about having multiple ways of specifying assembly-name in the type-alias, but also not happy about breaking xml-schema-validation on purpose (Though NLog-config-variables also doesn't work that well with xml-schema-validation. Ex.
minLevel="${var:defaultLevel}"
).Before NLog always ignored/stripped any prefix in type-name, but with this change then NLog will include the prefix when loading types. And will try to load assembly-name matching the prefix. Maybe this is for NLog 5.1 ? (Not sure of the original purpose of the prefix, and why it was ignored/skipped)