Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Slowness on Dev Server #330

Closed
allthesignals opened this issue May 20, 2020 · 7 comments
Closed

Investigate Slowness on Dev Server #330

allthesignals opened this issue May 20, 2020 · 7 comments
Assignees

Comments

@allthesignals
Copy link
Collaborator

What is causing the rebuild/refresh slowness for the dev server? The refresh seems slower than it does for other projects.

@bfreeds
Copy link

bfreeds commented May 26, 2020

Baseline

Initial Build
image

After initial build - hot reloading template changes
image

After Initial Build - hot reloading sass changes (related, #354 has been merged in the branch running this).
image

Resources / Research

@bfreeds
Copy link

bfreeds commented May 26, 2020

It looks like the rebuild times when changing hbs or js files is pretty quick, and the bottleneck is primarily being caused by the SASS compiler.

This is a known, open issue from 2015: adopted-ember-addons/ember-cli-sass#74

@bfreeds
Copy link

bfreeds commented May 27, 2020

During standup today, @godfreyyeung reported having ~6 second rebuild times. Need to examine packages and what might be different from Zola (which doesn't have such a slow rebuild).

@bfreeds
Copy link

bfreeds commented May 28, 2020

Checking ZOLA to see if there's differences in observed performance and project setup:

image

Rebuilding after change to template:
image

Rebuilding after change to SASS
image

@bfreeds
Copy link

bfreeds commented May 28, 2020

We should track this open PR, which I think will improve sass compile time: adopted-ember-addons/ember-cli-sass#215.

The other path for investigating is to hook up brocolli-inspector to get a deeper look at what the problem areas are. @allthesignals I'm not sure how the Usage fits with our monorepo, where the server/index.js the setup requires would go.

@allthesignals
Copy link
Collaborator Author

@bfreeds we could try to install that branch of ember-cli-sass on our project and see if it addresses the issue.

@allthesignals
Copy link
Collaborator Author

We cut down the rebuild time significantly. Closing for now but could improve the SASS build time issues in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants