Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: logging - Make the onbeforeunload logs push optional #1356

Open
dsebastien opened this issue Jul 14, 2019 · 0 comments
Open

core: logging - Make the onbeforeunload logs push optional #1356

dsebastien opened this issue Jul 14, 2019 · 0 comments
Projects
Milestone

Comments

@dsebastien
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Currently, the StarkLoggingServiceImpl class systematically adds a "beforeunload" event listener and pushes all remaining logs to the corresponding backend when it occurs.

Expected behavior

I would like to be able to disable this behavior so that I can fully control if/when logs are being sent (e.g., for privacy reasons; not all users opt into user tracking)

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z
Stark version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@dsebastien dsebastien added the comp: stark-core Stark Core label Jul 14, 2019
@SuperITMan SuperITMan added this to the 10.1.0 milestone Aug 6, 2019
@SuperITMan SuperITMan added this to To do in 10.1.0 via automation Jul 1, 2020
@SuperITMan SuperITMan removed this from To do in 10.1.0 Jul 24, 2020
@SuperITMan SuperITMan added this to To do in 10.2.0 via automation Jul 24, 2020
@SuperITMan SuperITMan modified the milestones: 10.1.0, 10.2.0 Jul 24, 2020
@SuperITMan SuperITMan modified the milestones: 10.2.0, 11.0.0 Mar 10, 2021
@SuperITMan SuperITMan added this to To do in 12.0.0 via automation Mar 10, 2021
@SuperITMan SuperITMan removed this from To do in 10.2.0 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
12.0.0
  
To do
Development

No branches or pull requests

2 participants