showcase: previous versions of the showcase are not accessible on PC Windows & Linux

[SuperITMan]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When we open https://stark.nbb.be, we are redirected on https://stark.nbb.be/showcase/latest/ which the latest version of our showcase.

We can also have access to the previous versions of the showcase by accessing:

• https://stark.nbb.be/showcase/10.0.0-rc.2/
• https://stark.nbb.be/showcase/10.0.0-rc.1/
• https://stark.nbb.be/showcase/10.0.0-rc.0/
• https://stark.nbb.be/showcase/10.0.0-beta.8/

Unfortunately, those links can be accessed on Android and iPhone devices but not on Windows and Linux systems.
On those ones, it results to a loop on "https://stark.nbb.be/showcase/10.0.0".

This is due to the fact we have the - character in the folder name. More information is available here: https://help.github.com/en/github/working-with-github-pages/troubleshooting-custom-domains-and-github-pages#url-formatting-on-linux

Also, on all the tested devices, accessing "https://stark.nbb.be/showcase/10.0.0-rc.0/home" results in a loop on "https://stark.nbb.be/showcase/10.0.0"...

Expected behavior

The previous versions of Stark should be accessible from any device and the links to access them should documented somewhere in the showcase.

Minimal reproduction of the problem with instructions

Open https://stark.nbb.be/showcase/10.0.0-rc.0/ on a PC.

What is the motivation / use case for changing the behavior?

Bug fixing

Environment

Stark version: 10.0.0-rc.3


Browser:
- [X] Chrome (desktop) version 79
- [X] Chrome (Android) version 79
- [X] Chrome (iOS) version 79
- [X] Firefox version 72
- [ ] Safari (desktop) version XX
- [X] Safari (iOS) version 13
- [X] IE version 11
- [X] Edge version 42

Others:

[christophercr]

Mmm I don't have any problem loading these urls from a Windows PC:

• https://stark.nbb.be/showcase/10.0.0-rc.2/
• https://stark.nbb.be/showcase/10.0.0-rc.1/
• https://stark.nbb.be/showcase/10.0.0-rc.0/
• https://stark.nbb.be/showcase/10.0.0-beta.8/

But there is indeed an infinite loop while trying to open these:

• https://stark.nbb.be/showcase/10.0.0-rc.2/home
• https://stark.nbb.be/showcase/10.0.0-rc.1/home
• https://stark.nbb.be/showcase/10.0.0-rc.0/home
• https://stark.nbb.be/showcase/10.0.0-beta.8/home
• any showcase version ending with /home

The infinite loop is caused by the logic we implemented in https://github.com/NationalBankBelgium/stark/blob/gh-pages/404.html

Here is a description on how this logic behaves: #1058 (comment)

So it seems we need to improve this logic to get rid of such annoying loop 😉