Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(stark-ui): add logout button on the Session Timeout Warning dialog #3479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature(stark-ui): add logout button on the Session Timeout Warning dialog #3479

wants to merge 1 commit into from

Conversation

mhenkens
Copy link
Contributor

@mhenkens mhenkens commented Sep 20, 2022 •
edited

ISSUES CLOSED: #1731

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1731

What is the new behavior?

The Logout Button is added in the popup

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

coveralls commented Sep 20, 2022 •
edited

Coverage Status

Coverage decreased (-0.07%) to 88.096% when pulling b9807aa on mhenkens:bugfix/1731 into 3dd16dd on NationalBankBelgium:master.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mhenkens mhenkens changed the title fix(stark-ui): add logout button on the Session Timeout Warning dialog feature(stark-ui): add logout button on the Session Timeout Warning dialog Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperITMan SuperITMan Awaiting requested review from SuperITMan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: session - add a "Disconnect" button to the Session Timeout Warning Dialog
2 participants
@mhenkens @coveralls