Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: some tests related to angular2-text-mask are failing #2860

Open
SuperITMan opened this issue Jul 26, 2021 · 0 comments
Open

ui: some tests related to angular2-text-mask are failing #2860

SuperITMan opened this issue Jul 26, 2021 · 0 comments

Comments

@SuperITMan
Copy link
Member

SuperITMan commented Jul 26, 2021

I'm submitting a...


[X] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

After upgrade to Angular 12, following tests are failing in StarkInputMaskDirectivesModule

  • NumberMaskDirective > with ngModel > should refresh the mask whenever the configuration changes
  • TextMaskDirective > with ngModel > should refresh the mask whenever the configuration changes
  • TextMaskDirective > with ngModel > should show/hide the mask placeholders depending of the value of the 'guide' option
  • TimestampMaskDirective > with ngModel > should refresh the mask whenever the configuration changes

with following error:

Error: NG0100: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: '12/3_/____'. Current value: '12-3_'.. Find more at https://angular.io/errors/NG0100

To not block the first part of the migration to Angular 12, the tests have been excluded and a // FIXME comment above each excluded test.

Expected behavior

No test should be excluded.

Environment


Angular version: 12.x

@SuperITMan SuperITMan added this to the 11.0.0 milestone Jul 26, 2021
@SuperITMan SuperITMan added this to To do in 12.0.0 via automation Jul 26, 2021
@SuperITMan SuperITMan changed the title ui: tests related to angular2-text-mask are failing ui: some tests related to angular2-text-mask are failing Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
12.0.0
  
To do
Development

No branches or pull requests

1 participant