Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-sorting on stark-table not working after sorting on single field #3580

Open
mhenkens opened this issue Feb 10, 2023 · 0 comments · May be fixed by #3593
Open

Multi-sorting on stark-table not working after sorting on single field #3580

mhenkens opened this issue Feb 10, 2023 · 0 comments · May be fixed by #3593
Assignees

Comments

@mhenkens
Copy link
Contributor

mhenkens commented Feb 10, 2023

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When using multisorting on the table, and then using the click on the arrow of a field, and set a new sort with the sort dialog the mutltisort is not display correctly on the table header

Expected behavior

Multi sort display correctly

Minimal reproduction of the problem with instructions

Step 1:
Access the screen where multi-sorting is defined as depicted in tableDefaultOrder property
Step 2:
Sort on any single field on the table
Step 3:
Add new fields in multi-sorting menu.
Step4 save

Screen.Recording.2023-03-16.at.14.15.16.mov

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z
Stark version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@mhenkens mhenkens self-assigned this Feb 10, 2023
mhenkens added a commit to mhenkens/stark that referenced this issue Feb 10, 2023
… on single field

Fix the issue using the chnageDetection strategy.

ISSUES CLOSED: NationalBankBelgium#3580
mhenkens added a commit to mhenkens/stark that referenced this issue Feb 21, 2023
… on single field

Fix the issue using the chnageDetection strategy.

ISSUES CLOSED: NationalBankBelgium#3580
mhenkens added a commit to mhenkens/stark that referenced this issue Feb 22, 2023
… on single field

Fix the issue using the chnageDetection strategy.

ISSUES CLOSED: NationalBankBelgium#3580
mhenkens added a commit to mhenkens/stark that referenced this issue Mar 21, 2023
… on single field

The issue was caused by the fact the ngClass multisorting was not changed.

ISSUES CLOSED: NationalBankBelgium#3580
mhenkens added a commit to mhenkens/stark that referenced this issue Mar 21, 2023
… on single field

The issue was caused by the fact the ngClass multisorting was not changed.

ISSUES CLOSED: NationalBankBelgium#3580
mhenkens added a commit to mhenkens/stark that referenced this issue Mar 21, 2023
… on single field

Fix the issue using the chnageDetection strategy.

ISSUES CLOSED: NationalBankBelgium#3580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant