Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: correlation-id not generated when loggingFlushDisabled == true #3620

Open
SuperITMan opened this issue Jul 6, 2023 · 0 comments
Open
Labels
10.x Stark version 12.x Stark version comp: stark-core Stark Core type: bug
Milestone

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Disabling the loggingFlush breaks the keep-alive since the correlation-id is not generated.

Expected behavior

The KeepAlive service should be usable without enabling the loggingFlush.

Minimal reproduction of the problem with instructions

In the file "stark-app-config.json", set the property loggingFlushDisabled: true with keepAlive enabled.
Start the application and check the request headers for the keep-alive requests. The header "correlation-id" is undefined.

What is the motivation / use case for changing the behavior?

Solve a bug.

Environment


Angular version: 7+
Stark version: 10+


Others:

@SuperITMan SuperITMan added type: bug comp: stark-core Stark Core 10.x Stark version 12.x Stark version labels Jul 6, 2023
@SuperITMan SuperITMan added this to the 10.3.3 milestone Jul 6, 2023
SuperITMan added a commit to SuperITMan/stark that referenced this issue Jul 6, 2023
SuperITMan added a commit to SuperITMan/stark that referenced this issue Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.x Stark version 12.x Stark version comp: stark-core Stark Core type: bug
Projects
None yet
Development

No branches or pull requests

1 participant