Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase: lazy load ExampleViewerModule after login #3650

Open
SuperITMan opened this issue Nov 14, 2023 · 0 comments
Open

showcase: lazy load ExampleViewerModule after login #3650

SuperITMan opened this issue Nov 14, 2023 · 0 comments

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[X] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Due to #2953, first navigation to a page under "Stark UI", "Stark Core", "Stark RBAC"... takes a while since the ExampleViewerModule is downloaded just before opening the page.
The bundle of 10MB is downloaded at that time.

Expected behavior

The ExampleViewerModule module should be lazyloaded before accessing the pages, since we are sure that these pages will be accessed.
We could load the module once the home page has been loaded.

Minimal reproduction of the problem with instructions

Start the showcase, open the DevTools and access to a page in "Stark UI", check the Network tab.

What is the motivation / use case for changing the behavior?

Fix UX after improvement thanks to the split of the stark-ui chunks.

Environment


Angular version: 12.x
Stark version: 12.x

@SuperITMan SuperITMan added this to the 12.0.0-rc.0 milestone Nov 14, 2023
@SuperITMan SuperITMan added this to To do in 12.0.0 via automation Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
12.0.0
  
To do
Development

No branches or pull requests

1 participant