Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: replace @npmcli/ci-detect dependency by ci-info #3658

Open
SuperITMan opened this issue Dec 1, 2023 · 0 comments
Open

testing: replace @npmcli/ci-detect dependency by ci-info #3658

SuperITMan opened this issue Dec 1, 2023 · 0 comments
Labels
comp: stark-testing dependencies Pull requests that update a dependency file good first issue
Projects
Milestone

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

stark-testing is using @npmcli/ci-detect library in Karma in order to detect if it is running in a CI environment.

⚠️@npmcli/ci-detect has been deprecated.

What is the motivation / use case for changing the behavior?

We should not use deprecated libraries. We should use the new recommended library instead: ci-info

@SuperITMan SuperITMan added comp: stark-testing dependencies Pull requests that update a dependency file labels Dec 1, 2023
@SuperITMan SuperITMan added this to the 12.0.0-rc.0 milestone Dec 1, 2023
@SuperITMan SuperITMan added this to To do in 12.0.0 via automation Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: stark-testing dependencies Pull requests that update a dependency file good first issue
Projects
12.0.0
  
To do
Development

No branches or pull requests

1 participant