Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal route issue - route runs twice when returning from second modal containing route outlet #96

Open
JWiseCoder opened this issue Nov 3, 2022 · 1 comment

Comments

@JWiseCoder
Copy link

JWiseCoder commented Nov 3, 2022

This is most evident in iOS. I've set up a demo app:

https://stackblitz.com/edit/nativescript-stackblitz-templates-vwcmqt

In iOS, if you follow the steps (they're numbered) you'll see that when you navigate back on step five, the animation runs twice—backwards then forwards. This appears to come from the shouldDetach method NSRouteReuseStrategy. If I use the previous code for shouldDetatch that was altered here:

bebcde2

then it works without problem.

NOTE: For this demo, I've used 14.2.6-alpha.0 because without it, I can't use modals with ModalDialogParams because of injector scope issues. However, this router problem described above also occurs in 14.2.5 when the modal corrections are in place. Either way, something isn't working as it should.

@JWiseCoder JWiseCoder changed the title Route runs twice when returning from Route runs twice when returning from second modal containing route outlet Nov 3, 2022
@JWiseCoder JWiseCoder changed the title Route runs twice when returning from second modal containing route outlet Modal route issue - route runs twice when returning from second modal containing route outlet Nov 3, 2022
@Theo-Sioris
Copy link

We also have the exact same problem.
Rolling back to Angular 14 is the bandaid that did the job for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants