Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forced require of non-existant buffer #5359

Open
ray007 opened this issue Aug 19, 2020 · 0 comments
Open

forced require of non-existant buffer #5359

ray007 opened this issue Aug 19, 2020 · 0 comments

Comments

@ray007
Copy link

ray007 commented Aug 19, 2020

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.8.0
  • Cross-platform modules: 6.5.15
  • Android Runtime: 6.5.3
  • iOS Runtime: 6.5.2

Describe the bug
After updating the node_modules in my project including js-base64, starting the app resulted in an exception on trying to require the module buffer, which was never anywhere explicitly required.

According to the author (dankogai/js-base64#126 (comment)) the new version does check for existence of the Buffer object to maybe use it if available.

Expected behavior

Either do not add the require('buffer') or add buffer to the dependencies if not already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant