Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TestReadProjection/TestSparkReadProjection to use Spark's InternalRow #23

Open
omalley opened this issue Mar 14, 2018 · 1 comment

Comments

@omalley
Copy link
Contributor

omalley commented Mar 14, 2018

In starting to look at working on Iceberg's schema evolution for ORC, the current test case is full of Avro's types/data structures. That doesn't work at all for ORC, because I don't have any desire to build those bindings.

Therefore, I'll make a version of TestSparkReadProjection that uses Iceberg's Schema and Spark's InternalRow. That will work with all three files formats.

Should I fork the current test classes? Or should I change the current test to be more generic?

@rdblue
Copy link
Contributor

rdblue commented Mar 16, 2018

I'd say change the current test classes. The Avro module has its own TestReadProjection because it was easier to copy it than to mess with the build to have tests depend on other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants