Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to ImageSeries #543

Open
rly opened this issue Jul 11, 2023 · 1 comment
Open

Add attributes to ImageSeries #543

rly opened this issue Jul 11, 2023 · 1 comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users

Comments

@rly
Copy link
Contributor

rly commented Jul 11, 2023

As per discussion with NWB + CatalystNeuro team.

Add num_frames_per_external_file to ImageSeries. There is currently no way to figure this out without opening the image files.

This would help support a starting_time + sampling_rate method for time.

Also consider adding a way to allow adding a video file and not having it start at the first frame. This use case came up in Loren Frank's lab yesterday but is not a big deal if it is not supported.

@rly rly added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels Jul 11, 2023
@CodyCBakerPhD
Copy link
Contributor

CodyCBakerPhD commented Jul 11, 2023

Also consider adding a way to allow adding a video file and not having it start at the first frame. This use case came up in Loren Frank's lab yesterday but is not a big deal if it is not supported.

Sounds like instead of just num_frames_per_external_file or starting_frames, this could become frame_index_range which is a list of length-2 tuples, each tuple being start frame index and end frame index respectively. If using entire video, this would become (0, num_frames_in_that_video)

Also seems easiest to implement this in a separate neurodata type such as ExternalImageSeries (though it's annoying how the 'l' in 'External' looks so similar to the 'I' in 'Image'..., depending on text renderer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

No branches or pull requests

2 participants