Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make band_mean and band_sd in DecompositionSeries optional #570

Open
rly opened this issue Feb 5, 2024 · 0 comments
Open

Make band_mean and band_sd in DecompositionSeries optional #570

rly opened this issue Feb 5, 2024 · 0 comments
Labels
category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@rly
Copy link
Contributor

rly commented Feb 5, 2024

The docs for band_mean and band_sd in DecompositionSeries say that these fields are specific to Gaussian filters. Not all filters used in neurophysiology are Gaussian though, e.g., an LFP decomposition into alpha, beta, and gamma bands is not Gaussian, and LFP decomposition is supposed to be supported by this neurodata type. These table columns should be optional.

Relatedly, the DecompositionSeries.bands table should be its own type. See #336

@rly rly added category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

1 participant