Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when reading a ISO15693 NFC dump that used to work in older versions. #51

Open
ffurano opened this issue Mar 22, 2024 · 11 comments
Open
Labels
invalid This doesn't seem right needs-more-info Requires more information to triage

Comments

@ffurano
Copy link

ffurano commented Mar 22, 2024

Hi, loading an NFC dump that used to work in previous versions now crashes the F0.

The Flipper reboots and then the screen shows this message:

flipper crashed but has been rebooted

malloc(0)

The CLI log of the crash seems to point to the zolotaya_korona_parser:

47663 [T][StorageApi] File 00005FF0 - 0000D69C open (/data/plugins/zolotaya_korona_parser.fal)
747708 [I][Elf] Total size of loaded sections: 2012
747711 [T][StorageApi] File 00005FF0 - 0000D69C closed
747714 [T][StorageApi] File/Dir 00005FF0 free
747716 [D][Fap] Library for NfcSupportedCardPlugin, API v. 1 loaded
747721 [T][StorageApi] Dir 000031C8 - 0000A5CC closed
747723 [T][StorageApi] File/Dir 000031C8 free
747726 [D][NfcSuppo ....... CRASH!...REBOOT!

Funnily enough, the log never prints the filename that it should have been opening.

I attach the file in question... zipped
nfc-crash-f0.zip

It's content is like follows:

$ cat nfc-crash-f0.nfc
Filetype: Flipper NFC device
Version: 3
# Nfc device type can be UID, Mifare Ultralight, Mifare Classic or ISO15693
Device type: ISO15693
# UID is common for all formats
UID: 5C 66 AA 95 32 C1 07 E0
# Data Storage Format Identifier
DSFID: 00
# Application Family Identifier
AFI: 00
IC Reference: 00
# Number of memory blocks, usually 0 to 256
Block Count: 0
# Size of a single memory block, usually 4
Block Size: 00
Data Content:
# First byte: DSFID (0x01) / AFI (0x02) / EAS (0x04) / PPL (0x08) lock info, others: block lock info
Security Status: 00
# Subtype of this card (0 = ISO15693, 1 = SLIX, 2 = SLIX-S, 3 = SLIX-L, 4 = SLIX2)
Subtype: 00
# End of ISO15693 parameters

Reproduction

Switch on
Load my .nfc file from the memory card
(system crash)

Anything else?

Also saving correctly decoded ISO15693 files leads to a crash, yet different. Will document in a different ticket

@Willy-JL
Copy link
Member

Are you able to read that card and save it again?

@ffurano
Copy link
Author

ffurano commented Mar 22, 2024

From a computer you mean? Yes.

@Willy-JL
Copy link
Member

No, from flipper of course. Can you read the card on flipper again, save it, and does that work?

@ffurano
Copy link
Author

ffurano commented Mar 22, 2024

No, it does not work. Just the act of loading it triggers the crash, as I wrote in the first message. This is 100% repeatable, I'd be curious to see if it has the same outcome also for others (you?). I had attached the incriminated file.
And I am sure that in some previous version of the FW it was working, I could load and save.

@Willy-JL
Copy link
Member

I am not asking about opening this file. I am asking about reading the physical card again.

@ffurano
Copy link
Author

ffurano commented Mar 22, 2024

I can list the content no probs if this is what you mean, and other files can be read ok (but they are not ISO15693)

@Willy-JL
Copy link
Member

I am asking about in your flipper going to NFC > Read, and touching the physical card, NOT the file, the real card in your hand, against the back of the flipper. Does that work?

@ffurano
Copy link
Author

ffurano commented Mar 22, 2024

NFC->Read always worked (but will give an error when saving an ISO15693 key)

This ticket is about NFC->Saved->nfc-crash-f0.nfc->crash

Does this answer your question?

@Willy-JL
Copy link
Member

This ticket is about NFC->Saved->nfc-crash-f0.nfc->crash

which is expected since this contains no data?

@Willy-JL
Copy link
Member

there are 0 blocks of 00 size...

please scan the tag in full and save it in full, then send that.

@Willy-JL Willy-JL added invalid This doesn't seem right needs-more-info Requires more information to triage labels Mar 23, 2024
@ffurano
Copy link
Author

ffurano commented Mar 23, 2024

A crash/reboot is definitely not the thing that one would expect for such a legitimate file content. The file is not empty, and at least contains an ID, and it could be loaded fine with the release of a few months ago. This is a new introduced bug.

I can't scan it in full and save it because there's another new bug that gives an error when saving it after being read OK. The outcome is that that kind of ISO15693 dongles can't be dealt with at all with recent releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right needs-more-info Requires more information to triage
Projects
None yet
Development

No branches or pull requests

2 participants