Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No change while bisecting, current was empty somehow #12

Open
Nilstrieb opened this issue Jan 23, 2023 · 2 comments
Open

No change while bisecting, current was empty somehow #12

Nilstrieb opened this issue Jan 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Nilstrieb
Copy link
Owner

Nilstrieb commented Jan 23, 2023

  213349ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no
  215275ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no
  217217ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no
  222527ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: yes
  222527ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no changes
thread 'main' panicked at 'internal error: entered unreachable code: No change while bisecting, current was empty somehow: {AstPath([])}', src/processor/checker.rs:173:17

while running the privatize pass on pi_ecs@0.1.0

@Nilstrieb
Copy link
Owner Author

Rerunning cargo-minimize fixes it

@Nilstrieb
Copy link
Owner Author

fa0b302 probably helps but what is really needed is a proper way to do this tracking..

I think I should probably start with a HasName trait implemented for all the syn structs.
And then using a bunch of macros define my own visitor trait that tracks this properly

@Nilstrieb Nilstrieb added the bug Something isn't working label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant