Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API: Use enum instead of #define for better codegen #10635

Open
roberth opened this issue May 2, 2024 · 0 comments
Open

C API: Use enum instead of #define for better codegen #10635

roberth opened this issue May 2, 2024 · 0 comments
Labels
c api Nix as a C library with a stable interface feature Feature request or proposal

Comments

@roberth
Copy link
Member

roberth commented May 2, 2024

Is your feature request related to a problem? Please describe.

Currently Rust bindgen generates u32 for #define NIX_OK, but nix_err is an int. This then requires an undue cast.

Other code generators will also have trouble associating a type with these, but a C enum could solve the problem.

Describe the solution you'd like

enum nix_err

Describe alternatives you've considered

Maybe some code generators don't know how to deal with enum's. I would consider such a code generator to be very unfinished.

Additional context

Priorities

Add 👍 to issues you find important.

@roberth roberth added feature Feature request or proposal c api Nix as a C library with a stable interface labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c api Nix as a C library with a stable interface feature Feature request or proposal
Projects
None yet
Development

No branches or pull requests

1 participant