New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when adding large local paths #4034
Comments
The "you'll be filling up your store with slight variations of large paths if you aren't careful" makes me think the overhaul should re-implement this warning before it could be considered merge-worthy. Since we currently have a warning for this, I feel it would be a step back to have it removed with no alternative. I also don't think the "is not a single file" criterion is a great idea to not warn on -- it might be intentional, but it also might not. Maybe there are files Sorry for being so negative 😬 |
I marked this as stale due to inactivity. → More info |
I closed this issue due to inactivity. → More info |
Is your feature request related to a problem? Please describe.
The
dumping large paths
message has been slightly helpful by providing a hint that something big is getting added to the store each time.This message is disappearing with #4030 (unless you use an older daemon), so you'll be filling up your store with slight variations of large paths if you aren't careful. Virtually nobody checks the size of their derivation closures.
Describe the solution you'd like
Provide a warning when adding a large local path to the store, when it is
Example warning
Describe alternatives you've considered
Nix flakes do alleviate the problem by only including (potentially unstaged!) files that are listed in git's staging area.
However, user can still reference paths that aren't in a repo.
Additional context
The text was updated successfully, but these errors were encountered: