duplicity: Fix finding Gio typelib #310514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a package just depended on GLib (or other bindings shipped with gobject-introspection),
wrapper was not needed since `${gobject-introspection}/lib/girepository-1.0` is implicitly on typelib path.
Now that GLib bindings were moved to `glib` package, `${glib}/lib/girepository-1.0` must be added
to `GI_TYPELIB_PATH` by the wrapper (or `gobject-introspection` setup hook for build time).
Simplest way to ensure that is using `wrapGApps*` hook.
Let鈥檚 also ensure that there is just one wrapper instead of three.
|
Do you know the steps to reproduce the error with duplicity on its own? |
|
Openrazer got almost same issue, but with |
|
鉁旓笍 With this fix I was able to run a backup successfully! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, if a package just depended on GLib (or other bindings shipped with gobject-introspection), wrapper was not needed since
${gobject-introspection}/lib/girepository-1.0is implicitly on typelib path. Now that GLib bindings were moved toglibpackage,${glib}/lib/girepository-1.0must be added toGI_TYPELIB_PATHby the wrapper (orgobject-introspectionsetup hook for build time).Simplest way to ensure that is using
wrapGApps*hook. Let鈥檚 also ensure that there is just one wrapper instead of three.Untested, supposedly fixes #310492
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.