Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1.1 npm tarball includes heroku/node_modules/ #1600

Closed
rarkins opened this issue Apr 20, 2021 · 1 comment
Closed

3.1.1 npm tarball includes heroku/node_modules/ #1600

rarkins opened this issue Apr 20, 2021 · 1 comment

Comments

@rarkins
Copy link

rarkins commented Apr 20, 2021

Issue

The published tarball for redis@3.1.1 adds a large number of unnecessary files, mostly in the heroku/node_modules/ directory.

You can see the diff here: https://app.renovatebot.com/package-diff?name=redis&from=3.1.0&to=3.1.1

Environment

Not relevavnt
@rarkins
Copy link
Author

rarkins commented Apr 20, 2021

3.1.1 also reverts the addition of a strange file a.js from redis@3.1.0:

image

leibale added a commit that referenced this issue Apr 20, 2021
@leibale
fix #1600 - exclude unnecessary files from tarball
719222b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rarkins