fix: use eth_maxPriorityFeePerGas for determing gas
#5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d62d268 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kanej
force-pushed
the
fix/max-priority-fee-per-gas
branch
from
4afda99
to
60cd478
Compare
kanej
force-pushed
the
fix/max-priority-fee-per-gas
branch
from
60cd478
to
5925fe0
Compare
kanej
force-pushed
the
fix/max-priority-fee-per-gas
branch
from
5925fe0
to
13ee80c
Compare
Update `getFeeData` to match the `ethers` algorithm, specifically don't just assume `1_000_000_000n` as the `maxPriorityFeePerGas`. Instead call `eth_maxPriorityFeePerGas`, and only fall back to `1_000_000_000n` if there is no response. Fixes #5093
kanej
force-pushed
the
fix/max-priority-fee-per-gas
branch
from
13ee80c
to
d62d268
Compare
kanej
commented
May 7, 2024
alcuadrado
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
getFeeDatato match theethersalgorithm, specifically don't just assume1_000_000_000nas themaxPriorityFeePerGas. Instead calleth_maxPriorityFeePerGas, and only fall back to1_000_000_000n, if there is no response.Fixes #5093