Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stale instanceIds should be sent as error in callback, not as TypeError #120

Open
kenr opened this issue Dec 11, 2017 · 0 comments
Open

Comments

@kenr
Copy link
Contributor

kenr commented Dec 11, 2017

Example:
If doing a adapter.getServices on a stale deviceInstanceId a TypeError is thrown, but instead it should be mediated as an error the callback.

List of methods that do not check instanceId

const connectionHandle = this.getDevice(deviceInstanceId).connectionHandle;

const device = this.getDevice(deviceInstanceId);

const device = this.getDevice(service.deviceInstanceId);

const device = this.getDevice(service.deviceInstanceId);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant