New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use pc-ble-driver-js with electron 4.0.8 #214
Comments
I had to make a few changes to pc-ble-driver-js build for it to work with electron 4. I referred to nodejs/node-addon-api#269 (comment). I am wondering how other users are getting it to work. |
@pambardekar we have not taken the electron 4 prebuilt binaries into use internally yet, so it might be that there are some issues hidden there. |
@bihanssen I am also trying to upgrade my application to Electron 4. Electron >=4.0.4 bumped the NMV to 69 and the NMV used to build the electron 4 binaries is 64. Do you have plans to publish updated binaries to support Electron >= 4.0.4? |
@christophgreen. the plan is to release a new version of pc-ble-driver-js within the next weeks. It will also include fix #216 related to electron 4. |
@bihanssen Any update on when this will be available? |
@christophgreen, some delays due to integration tests, will be out once resolved. |
There is a fix for this issue in v2.6.0. @christophgreen Can you confirm that it works for you? |
@alwa-nordic Yes we were able to get this running with electron 4.1. I'll open an issue if we encounter any other problems while testing the updated library. |
Does anyone have a sample electron application implementing pc-ble-driver-js ? |
@shaneeelliott , yes we do, our application is: https://github.com/NordicSemiconductor/pc-nrfconnect-core which contains pc-ble-driver-js, the module itself is used in the app that core loads: https://github.com/NordicSemiconductor/pc-nrfconnect-ble |
We have been using pc-ble-driver-js 2.4.3 with electon 1.8.1. With the latest 2.5.1 release, I am trying to upgrade to electron 4.0.8. When loading the pc-ble-driver-js node module I am getting following error:
XXXX\node_modules\electron-log\renderer.js:34 [10:14:51.109] Failed to add module. Error: Error: The specified procedure could not be found.
\?\XXXXX\node_modules\pc-ble-driver-js\build\Release\pc-ble-driver-js-sd_api_v2.node
This error generally indicates that a required DLL is missing. I have used dependency walker to check the dependencies but I couldn't nail down the error.
I have Visual Studio 2015 installed. I also have VC++ 2015 redistributable packages installed.
Is there any other dependency that needs to be installed?
The text was updated successfully, but these errors were encountered: