Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characteristic object should be identical for incoming and outgoing objects #75

Open
kenr opened this issue Oct 1, 2017 · 1 comment
Milestone

Comments

@kenr
Copy link
Contributor

kenr commented Oct 1, 2017

The JavaScript part of the driver should have identical objects for incoming data and outgoing data for a Characteristic.

Inbound processing of the object handles conversion of write_wo_resp and auth_signed_wr (

props.write_wo_resp = characteristic.properties.writeWoResp || false;
), but outgoing data from driver use write_wo_resp and auth_signed_wr instead of coverting the attributes to writeWoResp and authSignedWr (
const properties = characteristic.char_props;
)

@bihanssen bihanssen added this to the v3.0.0 milestone Oct 2, 2017
@bihanssen
Copy link
Contributor

Thanks, will fix in next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants