Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy only if e2e test passed on main #128

Open
Bogay opened this issue May 29, 2023 · 3 comments
Open

Deploy only if e2e test passed on main #128

Bogay opened this issue May 29, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Bogay
Copy link
Member

Bogay commented May 29, 2023

@uier FYI

https://blog.cloudflare.com/introducing-deploy-hooks-for-cloudflare-pages/
@Bogay Bogay added the enhancement New feature or request label May 29, 2023
@Bogay
Copy link
Member Author

Bogay commented May 29, 2023

BTW, deploy hooks allow us to deploy new pages only when the source code changes; some changes that only affect the documentation (e.g. README.md) don't need to build a new version.

@uier
Copy link
Member

uier commented Jun 5, 2023

現在 PR 跑的測試應該要是該 branch 起的 webServer，只有合到 main 的時候才需要跑 noj.tw？

@uier
Copy link
Member

uier commented Jun 7, 2023

UPDATE: the expected changes are that cloudflare deployment should launch after CI passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
NOJ Board
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bogay @uier