Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind checked instead of true/false-value, and show hidden stat… #82

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

uier
Copy link
Member

@uier uier commented Mar 14, 2023

…us in problem list

close #81
close #83

@uier uier self-assigned this Mar 14, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96ca8cb
Status: ✅  Deploy successful!
Preview URL: https://7587ab59.nfe.pages.dev
Branch Preview URL: https://fix-81.nfe.pages.dev

View logs

Copy link
Member

@Bogay Bogay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

沒看到啥問題,就是 hidden/visible 的 label 沒做 i18n 不曉得重不重要。

@@ -80,6 +83,9 @@ const maxPage = computed(() => {
<td>
{{ problemName }}
</td>
<td v-if="rolesCanReadProblemStatus.includes(session.role)">
<span class="badge ml-1">{{ status === 0 ? "VISIBLE" : "HIDDEN" }}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看來這邊以後需要做 i18n?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另開 issue,這個先 merge

@uier uier merged commit 94d8885 into main Mar 17, 2023
uier added a commit that referenced this pull request Mar 17, 2023
uier added a commit that referenced this pull request Mar 17, 2023
@uier uier deleted the fix/81 branch March 17, 2023 05:56
@uier uier restored the fix/81 branch March 17, 2023 05:56
@uier uier mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants