Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-compilation broken with latest release #55

Closed
trinity-1686a opened this issue Jul 19, 2023 · 1 comment · Fixed by #56
Closed

cross-compilation broken with latest release #55

trinity-1686a opened this issue Jul 19, 2023 · 1 comment · Fixed by #56
Assignees
Labels
bug Something isn't working

Comments

@trinity-1686a
Copy link

Cross compilation is somewhat broken in 0.10.0 due to the use of a build-script to set cfg flags.

To reproduce, on linux (no need for a full CC toolchain with clang, rustc is enough):

rustup target add x86_64-apple-darwin
cargo check --target x86_64-apple-darwin

A build-script was introduced, I assume to reduce lengthy cfg!(). Sadly it doesn't work as intended. target_os, target_env &co inside a build-script correspond to the host, not the real target, as the build-script is always compiled to be run on the host. This leads to rlimit__has_prlimit64 being set, based on the linux host having that feature, when the target is actually macOS, which shouldn't have it (it seems)

@Nugine Nugine added the bug Something isn't working label Jul 19, 2023
@Nugine Nugine self-assigned this Jul 19, 2023
@Nugine Nugine mentioned this issue Jul 19, 2023
@trinity-1686a
Copy link
Author

thanks for the quick fix! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants