Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a sign manually does not add UUIDs #6

Open
villermen opened this issue Dec 21, 2019 · 1 comment
Open

Creating a sign manually does not add UUIDs #6

villermen opened this issue Dec 21, 2019 · 1 comment

Comments

@villermen
Copy link

If you add a sign and type out the names manually, no UUID gets added after the added names (like with /lock 3 [playername]).

If you select a sign created this way with the first user being you, the UUID will be added.

@Artoria2e5
Copy link

Artoria2e5 commented May 31, 2020

The part that handles the update does seem to try to fill in the UUID. The whole re-doing getSelectedSign thing seems a bit out of place though (shouldn't mess things up still, since it's a cache on the other side).
https://github.com/NyaaCat/LockettePro/blob/8b63feb/src/main/java/me/crafter/mc/lockettepro/LockettePro.java#L204-L210

The code that does it for the first player seems to be in another place:

// Cleanups - UUID
if (Config.isUuidEnabled()){
Utils.updateLineByPlayer(newsign, 1, player);
}

The main difference between the two seems to be that the "add sign" case performs an ID fetch immediately, while the updateUuidByUsername case does it async (you can't not do it async with all the web stuff). The edit sign case also has some username format checks, but that's unlikely to fail either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants