Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check config before reload #30

Open
phoenixlzx opened this issue Aug 12, 2018 · 2 comments
Open

Check config before reload #30

phoenixlzx opened this issue Aug 12, 2018 · 2 comments

Comments

@phoenixlzx
Copy link
Contributor

Provide a method for plugin reload commands.

Check all config files for YAML validity and some specific constant values before the actual reload, report error position and stop to prevent any data loss.

@RecursiveG
Copy link
Member

Not so practical. Only the plugin itself knows how to check the integrity.
YAML syntax check is all we can do.

@phoenixlzx
Copy link
Contributor Author

Actually YAML syntax is the most common cause of crash.

As for plugin-related constants, we simply reset to default value in memory to continue running, when no valid value found in configuration - without write into config files and notify in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants