Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPI misleading if accounts results are negative and positive in the report #157

Open
elicoidal opened this issue Feb 6, 2019 · 5 comments
Labels
enhancement good first issue no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Comments

@elicoidal
Copy link
Contributor

In the case you want to create a P&L with Revenue in positive numbers and Cost in negative numbers such as below example, the KPI to compare the column would be incorrectly calculated for the negative part of the report (in the example below 14.6% should be "-14.6%").

Suggestion: in Report MIS, Source Field, introduce a new option "Compare Columns (Absolute)" to allow comparison based on absolute calculation.

image

@sbidoul
Copy link
Member

sbidoul commented Feb 6, 2019

@elicoidal absolute comparison is available in the current version:

image

What would fit nicely is a new comparison method "Percentage (negative growth)" as a variant of the current percentage mode which consider that an decrease of the value means growth.

It should be actually quite trivial to implement.

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 16, 2022
@HaraldPanten
Copy link

@elicoidal are you planning to suggest a PR for this functionality?

@sbidoul

@sbidoul sbidoul added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 17, 2022
@sbidoul
Copy link
Member

sbidoul commented Jan 17, 2022

@HaraldPanten Unfortunately Eric Caudal passed away in 2019.

I'm marking this as no stale as this feature is still good to have, as described in #157 (comment).

@HaraldPanten
Copy link

So sorry for that. I didn't know.

THX Stéphane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

No branches or pull requests

3 participants