Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes #159

Open
alyngsoe opened this issue Feb 11, 2019 · 16 comments
Open

Footnotes #159

alyngsoe opened this issue Feb 11, 2019 · 16 comments
Labels
enhancement good first issue no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Comments

@alyngsoe
Copy link

Would it be possible in the report view to add a column for adding comments (in the report preview form), and also showing the column on the pdf report and xls export ?
Why: When the accountant is preparing reports for e.g. board meetings, it would be valuable if he/she could add short comments to specific report line. This could be "High costs from new machine impl." or "decreased sale on asia market" etc...

@alyngsoe alyngsoe changed the title Adding comment column to mis reports Adding comment column to mis reports Feb 11, 2019
@sbidoul
Copy link
Member

sbidoul commented Feb 11, 2019

That would be a valuable feature.

I see it rather as footnotes than a comment column, what do you think?

From the top of my head, this requires:

  • a new model (mis.report.instance.footnote) that associates the footnote text to a report cell, ie the couple (mis.report.subkpi, mis.report.instance.period).
  • an extension to the preview widget to allow entering the footnotes
  • updating the XLS and PDF exports to display the footnotes

@alyngsoe
Copy link
Author

@sbidoul ,
I actually discussed this with a current customer, and here we clearly are in the need of comments on report line level. Although footnotes would also be (another) nice feature ;-)

I cannot contribute directly with development ressources, but would be happy to help in anyway by testing, feedback etc..

@sbidoul
Copy link
Member

sbidoul commented Feb 11, 2019

@alyngsoe can you elaborate on which use case line-level comments resolve that cannot be resolved with footnotes?

@alyngsoe
Copy link
Author

@sbidoul
Use case 1: Tax control report.
We have a MIS tax report to show columns with "theoretical" and "actual" tax for each finansial account. When the company has an external financial audit, the internal accountant will look through this report and analyse differences. To explain the differences to the external accountant, he will need to put notes on all the report lines with differences.

@alyngsoe
Copy link
Author

@sbidoul If your suggestion of a footnote model could give us the option to display a footnote number on the report lines ( as you usually do in regular "footnote" usage), then the footnote solution would be sufficient for the feature request.

@sbidoul
Copy link
Member

sbidoul commented Feb 22, 2019

@alyngsoe Yes that was my idea indeed.

@sbidoul
Copy link
Member

sbidoul commented Feb 22, 2019

A simplified design could start with linking footnotes to the couple (mis.report.kpi, mis.report.instance), ie report rows instead of cells. Attaching footnotes to cells could be optional and/or added later.

A further simplification is to let user enter footnootes in the mis.report.instance form instead of using a dedicated javascript widget. This is a bit less comfortable but much easier to implement, and the result (preview, pdf, excel) is the same.

@alyngsoe
Copy link
Author

@sbidoul your simplificated solutions sounds good to me :-)

@sbidoul sbidoul changed the title Adding comment column to mis reports Footnotes Mar 25, 2019
@lili94
Copy link

lili94 commented Apr 23, 2019

hi @sbidoul i need also to add Note colomun to my balance sheet , it s possible for now thanks

@hectorHerreraTeigeiro
Copy link

This approach works for us also.

@hitrosol
Copy link

Adding the footnotes in the report will give this module more powerful....:)

@lili94
Copy link

lili94 commented Jul 28, 2019

@hitrosol does anyone start develop this features ?

@sbidoul
Copy link
Member

sbidoul commented Jul 28, 2019

BTW, I plan to organize a MIS Builder workshop / Q&A session during #OCAdays2019. This could be the opportunity to discuss most wanted features and opportunities for community funding.

@lili94
Copy link

lili94 commented Sep 18, 2019

hi @sbidoul any features about this issue thanks

@sbidoul
Copy link
Member

sbidoul commented Sep 28, 2019

@lili94 no one has proposed a PR nor funding for this so far.

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 16, 2022
@sbidoul sbidoul added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

No branches or pull requests

5 participants