broken on views with folded content ( e.g commit diff )

[shinenelson]

Expected Behavior

OctoLinker links the correct repository to the corresponding string in the file

What actually happened?

OctoLinker is ignorant of folded content and links the wrong repositories to the unfolded lines. I do not know how the OctoLinker API actually works. My guess is that the search function looks up only the unfolded lines, but the linking function ( the thing that actually link-ifies the content ) links onto the folded lines too.

URL

caddyserver/caddy@2609a72

Anything else we should know?

the screenshot is of the file in the URL mentioned above. Lines 13 through 20 were folded initially ( you can notice the missing whitepsace markers ( from Refined GitHub ) there ). I manually expanded the section to hover over one of the folded lines to show the link. The link on line 16 ( hovered ) was actually supposed to be on line 24.

And if you want to count the number of lines, it is the fourth line :

• during search, it looks up 20 + 4 = 24
• during link-ifying, it links at 12 + 4 = 16.

Note : this issue impacts split diffs as well, but it is resolved when the folded lines are expanded and OctoLinker does another pass of the file.

[stefanbuck]

Thanks for the very detailed report, really appreciated. I need to reserve some time to hunt for the root cause and to ensure a fix is not breaking other things.