Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-addin-dev-settings] Update commander dependency #337

Closed
TheSamsterZA opened this issue Nov 13, 2020 · 0 comments · Fixed by #339
Closed

[office-addin-dev-settings] Update commander dependency #337

TheSamsterZA opened this issue Nov 13, 2020 · 0 comments · Fixed by #339

Comments

@TheSamsterZA
Copy link
Contributor

Expected behavior

Using exported methods from office-addin-dev-settings should not cause compilation to fail.

Current behavior

My app fails to compile.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

Code snippet:

// app.ts
import { sideloadAddIn } from 'office-addin-dev-settings';

async function foo(path) {
  await sideloadAddIn(path, undefined, true);
}

tsc app.ts

This will fail to compile due to commander. The bug was reported in multiple issues on the repo, and a PR was merged in and released in the 5.0.0.

Context

I am building a CLI that wraps the great functionality provided by the packages that live here in this repo. Unfortunately, due to office-addin-dev-settings using an old version of the commander package, my NodeJS app fails to compile.

  • Operating System: Windows 10 Version 20H2
  • Node version: 15.1.0 with npm 6.14.8
  • Office version: Microsoft Office 2016 Version 2012 (Build 13510.20004 Click-to-Run), Beta Channel
  • Tool version: office-addin-dev-settings@1.8.8

Failure Logs

node_modules/commander/typings/index.d.ts:26:25 - error TS2689: Cannot extend 
an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?

26   class Command extends NodeJS.EventEmitter {
                           ~~~~~~

Found 1 error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant