Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to styled-components v4 #241

Closed
nico-bellante opened this issue Oct 15, 2018 · 3 comments
Closed

Upgrade to styled-components v4 #241

nico-bellante opened this issue Oct 15, 2018 · 3 comments
Labels
wont-fix Will not be fixed.
Milestone
Backburner

Comments

@nico-bellante
Copy link
Contributor

https://medium.com/styled-components/styled-components-v4-new-final-finalest-for-real-final-final-psd-fa4d83398a77
@nico-bellante nico-bellante added this to the Backburner milestone Oct 16, 2018
@nico-bellante
Copy link
Contributor Author

Currently not possible due to reduxjs/react-redux#914 (comment)

@nico-bellante
Copy link
Contributor Author

The react-redux issue has been resolved. There still remains an issue with jest-styled-components being upgraded. See branch https://github.com/OfficeDev/script-lab-react/tree/bugfix/241 for current status.

This issue is tracking the jest-styled-components upgrade to compatibility with v4 styled-components.

@Zlatkovsky
Copy link
Member

@nico-bellante , looks like we already are using styled-components 4.1.1. Closing. Please re-open if I misread it somehow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wont-fix Will not be fixed.
Projects
None yet
Milestone
Backburner
Development

No branches or pull requests
2 participants
@Zlatkovsky @nico-bellante