Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save execution logs #174

Closed
accforgithubtest opened this issue Oct 15, 2023 · 5 comments
Closed

Save execution logs #174

accforgithubtest opened this issue Oct 15, 2023 · 5 comments

Comments

@accforgithubtest
Copy link

accforgithubtest commented Oct 15, 2023

Is your feature request related to a problem? Please describe.
Persist execution logs for all actions (manual, cron, onstartup, etc) to a log file so it can be used later (review / log analysis using other tools, etc). Neat if can also be displayed on the UI after a restart.

Describe the solution you'd like
A log file using a common standard format stores the logs to a log file in the same directory as the config file (for docker volume simplicity sake, it can also be a different volume if need be).
Probably will need log rotation & automated clean up after x days - both of which can be specified via environment variables.

Describe alternatives you've considered
Pls suggest if there are alternatives already available. Apologies if I have missed something that exists already.

Additional context
Right now all the previous executions log are lost once the container restarts.

@jamesread
Copy link
Collaborator

heh, I did wonder when this request would be raised :-) It means I need to implement a whole log handling solution!

It does make sense though, thanks for the feature request. I'd like to fix some other stuff first and get the issues list down a bit more before I take this on - as it's a fairly chunky feature.

For anyone else reading this, +1ing the first post here with an Emoji is helpful for me to understand how many people want this feature.

@jamesread
Copy link
Collaborator

#147 has a good idea to specifically the log filename on a per action basis, like resultFile.

@jamesread jamesread changed the title Persist action execution logs Save execution logs Apr 27, 2024
jamesread added a commit that referenced this issue Apr 28, 2024
@jamesread
Copy link
Collaborator

Okay, I've beeb avoiding this for quite a while because I was worried about all the log handling, but actually if I just write the log file on competition it solves a hell of a lot of problems and is very easy.

The code doesn't yet load logs from disk at startup, but I'm going go handle that as a separate issue.

@jamesread
Copy link
Collaborator

jamesread commented Apr 29, 2024

Saving logs is now possible in OliveTin. This was included in the 2024.04.28 release, and is documented here; https://docs.olivetin.app/save-logs.html

Pinging those that expressed interest in this as a FYI - @accforgithubtest @edersong @kernelkaribou @callumgare @tboby @rwalkerands @Vinesma @TH0MVS

Very keen to hear feedback and comments.

@jamesread
Copy link
Collaborator

No feedback received, but got some ❤️'s so assume that is good enough after a month :-) Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants