Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .vsixmanifest to work on VS 2019 #86

Closed
wants to merge 1 commit into from
Closed

Updated .vsixmanifest to work on VS 2019 #86

wants to merge 1 commit into from

Conversation

vzilinas
Copy link

-Added VS2019 version to .vsixmanifest
-Deleted Microsoft.VisualStudio.Shell.11.0 because it doesn't satisfy VS2019

Tested with VS2019 and VS2017, seems to work

Resolves #84

@hansmbakker
Copy link

hansmbakker commented Apr 25, 2019

If you deleted Microsoft.VisualStudio.Shell.11.0, shouldn't it be deleted from the lib folder as well?

Also be aware that there is #85 (duplicate work) and that the VSIX will need to load asynchronously to work in VS2019

@vzilinas
Copy link
Author

It works without the asynchronous patch in VS2019 but it is going to be obsolete later.

But as it is a duplicate I'm closing mine.

@vzilinas vzilinas closed this Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Studio 2019 Install Failing
2 participants