Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: PhoneUri's generated by onesignal not "random enough" #1220

Closed
1 task done
Webrow opened this issue Jan 30, 2023 · 1 comment
Closed
1 task done

[Feedback]: PhoneUri's generated by onesignal not "random enough" #1220

Webrow opened this issue Jan 30, 2023 · 1 comment

Comments

@Webrow
Copy link

Webrow commented Jan 30, 2023

What's on your mind?

There doesn't seem to be a better way for me to get into contact with the developers. So I hope you can get it into the right channels within the company. While looking through our user tables something caught my eye which seemt very unlikely and its the following:
index for one of our apps we have 8 entries which have zeros for the last segement of the phoneuri.
This being a guid I went into the spec and saw a reaonable explanation. in UUIv1 the last segement is the MAC address of the host creating the UUID. In a lot of environments this is hidden (with good reason) but it reduces the amount of phone uri's with ~12 bits.
Which ofcourse in an enormous amount of use cases is still enough. Nevertheless I'd like to address the issue, and hope that internally it gets upgraded to uuiv4 or 7.

I know this post should not be here, but as I said,
no Idea where I could send this feedback.

index

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nan-li
Copy link
Contributor

nan-li commented Mar 20, 2024

Hi @Webrow sorry for the long delay.

I don't see that OneSignal has any properties called PhoneUri. Are you sure this is generated by OneSignal?

@nan-li nan-li closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants