Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AssertionError [ERR_ASSERTION]: Missing 'ios.bundleIdentifier' in app config. #139

Closed
1 task done
yeongchan1228 opened this issue Nov 10, 2022 · 2 comments · Fixed by #140
Closed
1 task done
Labels
Documentation Improvements or additions to documentation

Comments

@yeongchan1228
Copy link

What happened?

Run the expo install onesignal-expo-plugin command
{
"plugins": [
[
"onesignal-expo-plugin",
{
"mode": "development",
}
]
]
}
If you enter the contents in the app.js file and enter the expo start command, Assertion Error [ERR_ASSERTION]: Missing 'ios.bundleIdentifier' in app config.

Steps to reproduce?

1. expo install onesignal-expo-plugin command
2. Enter content in app.js
3. expo start

What did you expect to happen?

It was expected that the build would succeed and run normally.

OneSignal Expo SDK version

"expo": "~47.0.3"
"onesignal-expo-plugin": "^1.2.0",

Platform

Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@brismithers
Copy link
Contributor

Hi @yeongchan1228 thank you for reporting! I have confirmed this iOS-specific error message does happen even when you intend to run on Android. To my knowledge there isn't a way to specify you only want a single platform's config changes to be applied, the plugin will always apply to both iOS and Android.

On the iOS side we require ios.bundleIdentifier to be specified as we use it to modify the config to include the Notification Service Extension.

In your app.json file you will need to specify the bundle identifier:

    "ios": {
      "supportsTablet": true,
      "buildNumber": "<your_build_number_here>",
      "bundleIdentifier": "<your_bundle_identifier_here>"
    },

If you don't intend to ever deploy to iOS, you can provide any non-empty string to the bundleIdentifier, the Android builds will work!

I've noted our README does not include this information. I will leave this issue opened until we can get the README updated to indicate ios.bundleIdentifier is also required to exist. Thanks!

@RizwansAccount
Copy link

Screenshot_1
in app.json file add bundleidentifier in ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
3 participants